Skip to content

Implement cli commander #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Implement cli commander #17

merged 3 commits into from
Aug 3, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Jul 30, 2021

Motivation

This PR introduces a new way to call arduino-cli commands.
The commands packages of arduino-cli have been imported and directly used.
This removes the dependency from arduino-cli, this means that arduino-cli is no longer required to be run in daemon mode.

Change description

Additional Notes

jira issue: https://arduino.atlassian.net/browse/IOT-1264

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

polldo added 2 commits July 30, 2021 15:56
Compile is not required at the moment
arduino-cli packages have been imported in order to directly call the commands packages.
This allows to remove arduino-cli daemon as a requisite.
Moreover, this completely remove the needs to have arduino-cli installed.
@polldo polldo requested a review from zmoog July 30, 2021 14:43
@polldo polldo changed the title Polldo/import cli packages Implement cli commander Jul 30, 2021
@polldo polldo merged commit 1fbe184 into main Aug 3, 2021
@polldo polldo deleted the polldo/import-cli-packages branch August 3, 2021 16:11
polldo added a commit that referenced this pull request Sep 2, 2022
arduino-cli packages have been imported in order to directly call the arduino-cli commands packages.
This allows to remove arduino-cli daemon as a requisite.
Moreover, this completely remove the needs to have arduino-cli installed.
Compile is not required at the moment

* Remove compile from commander interface

* Implement cli commander

* Update readme
polldo added a commit that referenced this pull request Sep 2, 2022
arduino-cli packages have been imported in order to directly call the arduino-cli commands packages.
This allows to remove arduino-cli daemon as a requisite.
Moreover, this completely remove the needs to have arduino-cli installed.
Compile is not required at the moment

* Remove compile from commander interface

* Implement cli commander

* Update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants